Attention is currently required from: osmith, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28602 )
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Patch Set 6: Code-Review+1
(5 comments)
File src/cbc_main.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/e013a1f6_67186dc1
PS4, Line 284: perr
copy+paste error. Should be SBc-AP ad not CBSP.
Done
File src/cbc_vty.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/2f0c309e_900164c0
PS4, Line 539: cfg_peer_proto
why is it deprecated?
Done
File src/message_handling.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/4241c3b9_0c2f5fc6
PS4, Line 151: CBSP
copy+paste
Done
File src/sbcap_server.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/4bf019c3_231c0aa5
PS4, Line 33: //#include <osmocom/gsm/sbcap.h>
: //#include <osmocom/gsm/protocol/gsm_48_049.h>
those can certainly go?
Done
File src/sbcap_server_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/14c336a1_3cb7e16e
PS4, Line 25: /
remove?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Jul 2022 09:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment