Attention is currently required from: osmith, pespin.

Patch set 6:Code-Review +1

View Change

5 comments:

• File src/cbc_main.c:

  • Patch Set #4, Line 284: perr

    copy+paste error. Should be SBc-AP ad not CBSP.

    Done

• File src/cbc_vty.c:

  • Patch Set #4, Line 539: cfg_peer_proto

    why is it deprecated?

    Done

• File src/message_handling.c:

  • Patch Set #4, Line 151: CBSP

    copy+paste

    Done

• File src/sbcap_server.c:

  • Patch Set #4, Line 33:

    //#include <osmocom/gsm/sbcap.h>
    //#include <osmocom/gsm/protocol/gsm_48_049.h>
    

    those can certainly go?

    Done

• File src/sbcap_server_fsm.c:

  • Patch Set #4, Line 25: /

    remove?

    Done

To view, visit change 28602. To unsubscribe, or for help writing mail filters, visit settings.