Attention is currently required from: fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32532 )
Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable) ......................................................................
Patch Set 12:
(2 comments)
This change is ready for review.
Patchset:
PS12: @fixeria: This patch should now be fixed. I have tested it with 1.5 and 2.0.0. I also followed your suggestion to use inline pylint pragmas but pylint seems to ignore them. Maybe you have an idea here.
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/32532/comment/11a5db4c_23e9ac80 PS12, Line 162: # pylint: disable=E1121 I have tested this also with too-many-function-args but it seems not to be recognized by pylint. As far as I understand the documentation this pylint pragma woul dbe valid for the entire block. I am running out of ideas here, maybe we should not indent using spaces?