Attention is currently required from: fixeria.

Hello osmith, Jenkins Builder, neels,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ggsn/+/31511

to look at the new patch set (#3).

Change subject: gtp: use OSMO_ASSERT() in gtp_new() ......................................................................

gtp: use OSMO_ASSERT() in gtp_new()

When using built-in static_assert() [1], gcc v12.2.1 fails:

In file included from gsn.c:27: gsn.c: In function 'gtp_new': gsn.c:444:54: error: expression in static assertion is not constant 444 | osmo_static_assert(gtp_T_defs[0].default_val != 0, first_default_val_not_zero); | ^

The reason is likely that gtp_T_defs[] is not const, so it cannot be assert()ed statically. With the current osmo_static_assert() implementation, this assert does nothing. One can change the gtp_T_defs[0].default_val to 0 and the code will still compile.

Change-Id: Ia8af1736b63d501661046fe70befe5bbabc1045a Related: [1] libosmocore.git I5ca34bc14c05e8c38c721d7df33feb1c6c41c76e --- M gtp/gsn.c 1 file changed, 24 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/11/31511/3