Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 )
Change subject: gmm: Implement rx GMM STATUS msg
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
You can go even more generic than the "Rx
foobar" and "msg_size check" by doing the tlv_parse in the […]
logging: We could move it to a generic place, but sometimes it's also useful to
log message specific stuff in the same Rx line, hence why I preferred keeping it
separate.
tlv_parse: GMM has a lot of adhoc IEs without T or L parts, which makes it difficult to
parse all messages generically. One needs to first manually parse the first fields which
are dependent on each message, until arriving to the TLV part.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/33001
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803
Gerrit-Change-Number: 33001
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 May 2023 14:20:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment