Attention is currently required from: jolly, lynxis lazus.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email )
Change subject: Also track downtime when OML link is lost
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35566/comment/4637eff3_ae293e19
PS1, Line 831: !bts->oml_link
A note for other reviewers: this is the key change of this patch.
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35566/comment/e1fd827b_a6a45626
PS1, Line 375: bts_updowntime
The command is called `oml-uptime`.
Maybe emulate the old behavior here (like you do in `bts_store_uptime()`)?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1776099cbfef51af1d5a3a056fb0654abd7366a9
Gerrit-Change-Number: 35566
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 15 Jan 2024 18:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment