[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues
Attention is currently required from: arehbein, daniel, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email )
Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ......................................................................
Patch Set 8:
(1 comment)
File src/core/gsmtap_util.c:
https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/1e28f701_1c259d04 PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);
it may make sense to look at what shutdown(sink_fd, SHUT_RD) may do to a UDP socket, perhaps it alre […]
hmm, looks like shutdown is not really implemented in UDP sockets: https://stackoverflow.com/questions/60105082/using-shutdown-for-a-udp-socket
In that case I guess we want to limit somehow the read buffer queue in the kernel to the minimum (even 0) to avoid wasting kb/mb of memory for each gsmtap socket sink with filled message that are never read.
-
pespin