Attention is currently required from: msuraev.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 )

Change subject: GSMTAP: allow configuring src IP for log messages ......................................................................

Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/bd8f8c87_143ccbba PS2, Line 7: configuring src IP for log messages Can you explain how might this be useful on practice?

File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/356b03ad_081eadb5 PS2, Line 180: logging source I am sorry, but to me it looks like a wrong direction. You're adding a general parameter, which only applies to GSMTAP target(s). The naming `logging source` is also quite unspecific: source what? IMO, it should be added as an optional parameter of the `log gsmtap` command: log gsmtap [HOSTNAME] [SRCADDR]

It's also unlikely that unsetting the source address is useful. Why would you want to unset that?