Attention is currently required from: msuraev.

Patch set 2:Code-Review -1

View Change

2 comments:

• Commit Message:

  • Patch Set #2, Line 7: configuring src IP for log messages

    Can you explain how might this be useful on practice?

• File src/vty/logging_vty.c:

  • Patch Set #2, Line 180: logging source

    I am sorry, but to me it looks like a wrong direction. You're adding a general parameter, which only applies to GSMTAP target(s). The naming `logging source` is also quite unspecific: source what? IMO, it should be added as an optional parameter of the `log gsmtap` command:
      log gsmtap [HOSTNAME] [SRCADDR]
      
    It's also unlikely that unsetting the source address is useful. Why would you want to unset that?

To view, visit change 31513. To unsubscribe, or for help writing mail filters, visit settings.