Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email ) Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 3: (4 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/9dd43fb6_8ce85… : PS3, Line 664: insertd Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/8bc371a9_66b09… : PS3, Line 736: return -ENODEV; I prefer keeping it this way since the typology of return is different here. The others are really unexpected state problems which deserve logging. This one here, on the other hand, is just the lookup failing and makes more sense that the caller logs whatever it pleases. Otherwise for instance if some VTY user types in some asp with a typo we end up with a error in log which really doesn't have any kind of problem during the normal operation of the program. https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/706a655f_eca27… : PS3, Line 857: LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: " Done File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/56e15297_69056… : PS3, Line 401: find The real only expected cause of this failing here is that the linkset cannot be found, so it's far more informative as it is now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Oct 2024 15:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>