Attention is currently required from: fixeria, osmith.
4 comments:
File src/osmo_ss7.c:
Patch Set #3, Line 664: insertd
inserted
Done
Patch Set #3, Line 736: return -ENODEV;
other error returns above log a message. […]
I prefer keeping it this way since the typology of return is different here.
The others are really unexpected state problems which deserve logging. This one here, on the other hand, is just the lookup failing and makes more sense that the caller logs whatever it pleases.
Otherwise for instance if some VTY user types in some asp with a typo we end up with a error in log which really doesn't have any kind of problem during the normal operation of the program.
Patch Set #3, Line 857: LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: "
maybe be more specific here: "Refusing to create route with existing linkset name"
Done
File src/osmo_ss7_vty.c:
set?
The real only expected cause of this failing here is that the linkset cannot be found, so it's far more informative as it is now.
To view, visit change 38375. To unsubscribe, or for help writing mail filters, visit settings.