Attention is currently required from: falconia.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email )
Change subject: fix E1 TS output when used with osmo-e1d
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
From what I can see, this patch is correct.
File src/libosmo-mgcp/mgcp_e1.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/37311/comment/1be0499c_43e88d39
PS1, Line 327: e1inp_ts_send_raw(ts, msg);
I believe that this API was not around in 2020 when I did the implementation. Or I simply
overlooked it. In any case, I believe this is correct.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2
Gerrit-Change-Number: 37311
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 12:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment