Attention is currently required from: daniel.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email )
Change subject: gtp: add support for SGSN Context Req/Resp/Ack ......................................................................
Patch Set 9:
(6 comments)
File include/osmocom/gtp/gsn.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20958): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/9907db47_d9e90beb?usp... : PS9, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20958): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/84924771_15d23d34?usp... : PS9, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20958): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/2af5b505_571b579b?usp... : PS9, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20958): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/7b0fc68f_e7367339?usp... : PS9, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20958): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/4f57b028_e6a08ded?usp... : PS9, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20958): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/89c4ec97_655a2925?usp... : PS9, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments