Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38049?usp=email ) Change subject: pySim-shell: Detect different eUICC types and print during start-up ...................................................................... Patch Set 8: (4 comments) File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/38049/comment/2597b3bc_99856f7b?usp=em… : PS6, Line 580: -> bool: Not addressed. https://gerrit.osmocom.org/c/pysim/+/38049/comment/30fed825_86a4e874?usp=em… : PS6, Line 598: -> bool: Not addressed. https://gerrit.osmocom.org/c/pysim/+/38049/comment/44cbb78e_d61f0499?usp=em… : PS6, Line 616: -> bool: Not addressed. File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/38049/comment/f7b7ab37_3e307c9c?usp=em… : PS8, Line 572: gc = unused variable? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02 Gerrit-Change-Number: 38049 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 14:13:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>