Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31529 ) Change subject: Interleaving for CSD ...................................................................... Patch Set 2: (2 comments) File src/coding/gsm0503_interleaving.c: https://gerrit.osmocom.org/c/libosmocore/+/31529/comment/cc067828_ba457d04 PS2, Line 712: j = (k % 19) + 19*(k % 6); Ack https://gerrit.osmocom.org/c/libosmocore/+/31529/comment/383518ca_bc0f82af PS2, Line 723: /* upper bound for B: 4*n + 18 + 4 = 4*n + 22 */ none of the other interleave/deinterleave functions in this file do, so I'll stick to consistency. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6b16c2d0d7febf3883da662b2c7fec543335de12 Gerrit-Change-Number: 31529 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 11:01:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment