Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31529 )
Change subject: Interleaving for CSD ......................................................................
Patch Set 2:
(2 comments)
File src/coding/gsm0503_interleaving.c:
https://gerrit.osmocom.org/c/libosmocore/+/31529/comment/cc067828_ba457d04 PS2, Line 712: j = (k % 19) + 19*(k % 6);
This would look nicer with space around *
Ack
https://gerrit.osmocom.org/c/libosmocore/+/31529/comment/383518ca_bc0f82af PS2, Line 723: /* upper bound for B: 4*n + 18 + 4 = 4*n + 22 */
Since index is the same for de/interleaving perhaps it makes sense to split it into static function […]
none of the other interleave/deinterleave functions in this file do, so I'll stick to consistency.
-
laforge