Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32630 )

Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................

Patch Set 2:

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/e3b5c5fa_851eb1ae PS2, Line 1963: if (OSMO_UNLIKELY(rfc5993 && !ts101318 && rtp_pl_len == GSM_HR_BYTES_RTP_TS101318)) { I'd really appreciate a more "step by step logic procedure" here, as in how one would thing about it, that is: """ if (OSMO_UNLIKELY(rtp_pl_len == GSM_HR_BYTES_RTP_TS101318 && !ts101318 && rfc5993)) """ This reads far better: if the received packet is TS101318 but the bts model doesn't support it, and it supports another format, then convert to that other format.

https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/aa456769_40e85f28 PS2, Line 1970: } else if (OSMO_UNLIKELY(ts101318 && !rfc5993 && rtp_pl_len == GSM_HR_BYTES_RTP_RFC5993)) { else not needed due to break immediatelly above.