laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38184?usp=email ) Change subject: trau2rtp EFR unit test: add patterns with bad CRC ...................................................................... trau2rtp EFR unit test: add patterns with bad CRC Unlike its FRv1 counterpart, the TRAU frame format for EFR includes CRC, intended to catch transmission errors in terrestrial circuits. Add some bad CRC patterns to the unit test for osmo_trau2rtp() EFR. Change-Id: Iee69b6a1593bdc8d11904a5f2ad46cd0fc6052a9 --- M tests/trau_conv/trau16_efr.in M tests/trau_conv/trau16_efr_std.ok M tests/trau_conv/trau16_efr_twts001.ok 3 files changed, 26 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/trau_conv/trau16_efr.in b/tests/trau_conv/trau16_efr.in index b4bdb02..0f113aa 100644 --- a/tests/trau_conv/trau16_efr.in +++ b/tests/trau_conv/trau16_efr.in @@ -78,3 +78,11 @@ 0000ebecca1b97f3b45086fffffc8000c68efffffe008046c07fffffe0008451fffcffe08004e2ff ID perfect SID with BFI=1 SID=0 0000ebe8ca1b97f3b45086fffffc8000c68efffffe008046c07fffffe0008451fffcffe08004e2ff + +# The following frames were also constructed by hand. They have bad CRC +# and thus test the handling of this case in osmo_trau2rtp(). + +ID all Dn bits set to 0 +0000ebe88000800080008000800080008000800080008000800080008000800080008000800082ff +ID all Dn bits set to 1 +0000ebe8fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffeff diff --git a/tests/trau_conv/trau16_efr_std.ok b/tests/trau_conv/trau16_efr_std.ok index 8fff73a..110cd0e 100644 --- a/tests/trau_conv/trau16_efr_std.ok +++ b/tests/trau_conv/trau16_efr_std.ok @@ -116,3 +116,11 @@ 0000ebe8ca1b97f3b45086fffffc8000c68efffffe008046c07fffffe0008451fffcffe08004e2ff TRAU frame type: EFR osmo_trau2rtp() result: 0 +ID all Dn bits set to 0 +0000ebe88000800080008000800080008000800080008000800080008000800080008000800082ff + TRAU frame type: EFR + osmo_trau2rtp() result: 0 +ID all Dn bits set to 1 +0000ebe8fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffeff + TRAU frame type: EFR + osmo_trau2rtp() result: 0 diff --git a/tests/trau_conv/trau16_efr_twts001.ok b/tests/trau_conv/trau16_efr_twts001.ok index 2b11d14..370d1ba 100644 --- a/tests/trau_conv/trau16_efr_twts001.ok +++ b/tests/trau_conv/trau16_efr_twts001.ok @@ -226,3 +226,13 @@ 0 12 15 15 15 15 12 0 0 0 0 0 17 12 12 15 12 15 15 12 0 0 0 0 0 19 SID recompute: 0 +ID all Dn bits set to 0 +0000ebe88000800080008000800080008000800080008000800080008000800080008000800082ff + TRAU frame type: EFR + osmo_trau2rtp() result: 1 + TW-TS-001 TEH octet: 0xE6 +ID all Dn bits set to 1 +0000ebe8fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffeff + TRAU frame type: EFR + osmo_trau2rtp() result: 1 + TW-TS-001 TEH octet: 0xE6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iee69b6a1593bdc8d11904a5f2ad46cd0fc6052a9 Gerrit-Change-Number: 38184 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>