Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30138 ) Change subject: rspro_client: implement re-establish delay ...................................................................... Patch Set 1: (5 comments) File src/rspro_client_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962): https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/2fb56f24_41996682 PS1, Line 61: #define REESTABLISH_DELAY_COUNT sizeof(k_reestablish_delay_s)/sizeof(k_reestablish_delay_s[0]) Prefer ARRAY_SIZE(k_reestablish_delay_s) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962): https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/4ee1174b_e3104353 PS1, Line 216: static int64_t get_monotonic_ms() Bad function definition - int64_t get_monotonic_ms() should probably be int64_t get_monotonic_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962): https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/2cac44b3_fe241958 PS1, Line 218: struct timespec t; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962): https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/ec1d3112_50da4864 PS1, Line 219: clock_gettime(CLOCK_BOOTTIME, &t); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962): https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/04062233_daaf4329 PS1, Line 220: return ((1000LL * t.tv_sec) + (t.tv_nsec / 1000000)); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I86cdc3ba37482e6577b429194d273a2399f32208 Gerrit-Change-Number: 30138 Gerrit-PatchSet: 1 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 14 Nov 2022 04:44:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment