View Change

5 comments:

• File src/rspro_client_fsm.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962):

    Patch Set #1, Line 61: #define REESTABLISH_DELAY_COUNT sizeof(k_reestablish_delay_s)/sizeof(k_reestablish_delay_s[0])

    Prefer ARRAY_SIZE(k_reestablish_delay_s)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962):

    Patch Set #1, Line 216: static int64_t get_monotonic_ms()

    Bad function definition - int64_t get_monotonic_ms() should probably be int64_t get_monotonic_ms(void)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962):

    Patch Set #1, Line 218: struct timespec t;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962):

    Patch Set #1, Line 219: clock_gettime(CLOCK_BOOTTIME, &t);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-962):

    Patch Set #1, Line 220: return ((1000LL * t.tv_sec) + (t.tv_nsec / 1000000));

    please, no spaces at the start of a line

To view, visit change 30138. To unsubscribe, or for help writing mail filters, visit settings.