Attention is currently required from: jolly, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 ) Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... Patch Set 2: (7 comments) File library/GSM_RR_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/7559ee54_ec9a… PS2, Line 590: HEX1 Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/a74d8c8c_cae8… PS2, Line 597: } with { variant "TAG(cksn, tag = 'B'H)" }; The way I did it, the IEI is tied to the message in whihc the IE occurs, and not to the IE itself. In GSM 04.08 and some other protocols there are instances where the same IE has different IEIs depending on where they appear. In this case, the IEI must be "glued" to the containing message, and not to the IE itself. In this specific instance, I don't know if the CipheringKeySeqNrTV occurs in other places (with or without different IEI). But I don't see anything wrong with it, given that also in the SPEC, the IEIs are listed in the message, and not in the definition of the IE. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/d35f1736_7b6d… PS2, Line 650: } with { variant (len) "LENGTHTO(es,spare,uai_rach,priority)" }; Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/c894a58f_6b93… PS2, Line 656: } with { variant "" }; Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/4c6da24f_2540… PS2, Line 663: } with { variant (len) "LENGTHTO(talker_id)" }; Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/5baa25bc_2922… PS2, Line 670: } with { variant "" }; Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/a2aa0f79_e329… PS2, Line 690: Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 08:54:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment