neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27246 )

Change subject: bsc: fix TC_ho_into_this_bsc_a5_4 ......................................................................

bsc: fix TC_ho_into_this_bsc_a5_4

This test should be failing as it is, because A5/4 is not permitted in the BSC's configuration! It only passed all this time because osmo-bsc is/was/is going to have been flawed and just takes the Chosen Encryption Algorithm IE as the basis for choosing an encryption algorithm. Instead it should intersect the pemitted algos with the BSC config. It will soon do that, and then this test would fail as it should have. After fixing the BSC config for the test with this patch, we'll not see it failing in the transition.

Related: SYS#5539 Change-Id: Ic6bbbeea36e6ea26d16bbb510fd08f5c0defb955 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/27246/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5b7243b..2cf6bc8 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6134,7 +6134,9 @@ }

testcase TC_ho_into_this_bsc_a5_4() runs on test_CT { + f_vty_encryption_a5("3 4"); f_tc_ho_into_this_bsc_a5(f_encr_params('10'O, kc128 := true)); + f_vty_encryption_a5_reset(); }

/* Report: in inter-BSC incoming handover, when the MSC omits the Chosen Encryption Algorithm IE in the Handover Request