Attention is currently required from: fixeria.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33495 )

Change subject: osmo_io: Use bitfield for various boolean flags ......................................................................

Patch Set 2:

(5 comments)

File src/core/osmo_io_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/0f45e21e_cb6c58be PS1, Line 39: iofd

`(iofd)->flags`, just to be safe

Ack

https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/78a42cab_daf522e8 PS1, Line 40: } while (0)

Agreeing with the linter, do-while wrapper is not really needed here.

Done

https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/094d0a26_92910ae9 PS1, Line 47: iofd->flags & flag

same here: `(iofd)->flags & (flag)`

Done

https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/8a099afd_04c1b77d PS1, Line 58: TODO: Move to bitfield

remove this TODO?

Ack

File src/core/osmo_io_poll.c:

https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/c73bcb46_6990a057 PS1, Line 84: FLAG_ISSET

missing `IOFD_` prefix

Done