Attention is currently required from: fixeria.

View Change

5 comments:

• File src/core/osmo_io_internal.h:

  • Patch Set #1, Line 39: iofd

    `(iofd)->flags`, just to be safe

    Ack

  • Patch Set #1, Line 40: } while (0)

    Agreeing with the linter, do-while wrapper is not really needed here.

    Done

  • Patch Set #1, Line 47: iofd->flags & flag

    same here: `(iofd)->flags & (flag)`

    Done

  • Patch Set #1, Line 58: TODO: Move to bitfield

    remove this TODO?

    Ack

• File src/core/osmo_io_poll.c:

  • Patch Set #1, Line 84: FLAG_ISSET

    missing `IOFD_` prefix

    Done

To view, visit change 33495. To unsubscribe, or for help writing mail filters, visit settings.