Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email )
Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/common/csd_v110.c:
https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/5121552c_66f0cf96?usp=... : PS1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */
I prefer using hex-notation when dealing with values sent/received over the wire/radio. […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/47530bdc_c42a0a50?usp=... : PS1, Line 125: * Q4 | =1 | =1
Yes, we do not execute this code for `i == 3` (i.e. […]
Ah I didn't see it was a loop, fine then.
-
pespin