Attention is currently required from: daniel, fixeria, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email )
Change subject: meas_feed: Use osmo_io instead of write queue ......................................................................
Patch Set 6:
(3 comments)
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/0d553836_798d4cea PS5, Line 148: &(struct osmo_io_ops) { : .read_cb = meas_feed_noop_cb, : .write_cb = meas_feed_noop_cb, : .segmentation_cb = NULL, : }, NULL);
The read callback (if set) also needs to free the msgb, otherwise we leak memory. […]
@vyanitskiy@sysmocom.de I have adapted the code, although I do find it helpful to see what is effectually being passed when using an unnamed struct.
@dwillmann@sysmocom.de Shouldn't we declare that part about freeing the msg buff in the comment for the `read_cb` member in `libosmocore.git:include/osmocom/core/osmo_io.h`?
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/4865ff1a_05d03cae PS5, Line 156: meas_feed_txqueue_max_length_set(MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT
This looks suspicious. I see a few potential problems: […]
Done
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/7c481d4b_6a9e9533 PS6, Line 33: static struct meas_feed_state g_mfs = {.txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT};
Not sure if we have preferred way in osmocom, but I'd prefer each initializer element on its own lin […]
I kind of like using a different style for structs as opposed to the style used for function definitions and elements of control flow. If it's not a must, I'd like to keep it this way
-
arehbein