Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29761 ) Change subject: msgb: introduce realloc functions ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: I think the main point of a realloc API is to avoid allocating a new chunk and having to copy over all the memory in the old chunk unless it's really unneeded. So I think msgb_copy() should be kept as it was, and msgb_realloc in any case implemented with "man realloc" API. The API you are proposing there is more actually "msgb_copy_new_length()" or something similar, not a realloc function. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615 Gerrit-Change-Number: 29761 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:01:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment