Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39747?usp=email ) Change subject: [6/6] personalization: refactor SdKey ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39747/comment/ccd47056_e6bd6df5?usp=em… : PS3, Line 296: def _apply_sd(cls, pe: ProfileElement, value): erm gerrit is formatting this comment so that i can only guess. Can you encaps your underscores in backticks like ~~~ `__` ~~~ Did you mean double underscores? If yes, then no. Double underscores are reserved for python interpreter internals! We may override doublescored functions and mess with python internals, but we should not make up new names with double underscores. The standard way of marking a private function is a single underscore at the start. It's not enforced, of course, because how could you enforce ANYTHING in python, we can even override `__getattr__()` and get a dir() of absolutely everything. Hope i did understand correctly! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I427ea851bfa28b2b045e70a19a9e35d361f0d393 Gerrit-Change-Number: 39747 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Mar 2025 22:23:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>