Attention is currently required from: dexter.

View Change

1 comment:

• File pySim/esim/saip/personalization.py:

  • Patch Set #3, Line 296: def _apply_sd(cls, pe: ProfileElement, value):

    If you want to make this method more private you can apply __ underscores instead of one _. […]

    erm gerrit is formatting this comment so that i can only guess. Can you encaps your underscores in backticks like
    ~~~
    `__`
    ~~~

    Did you mean double underscores?
    If yes, then no. Double underscores are reserved for python interpreter internals! We may override doublescored functions and mess with python internals, but we should not make up new names with double underscores.

    The standard way of marking a private function is a single underscore at the start.
    It's not enforced, of course, because how could you enforce ANYTHING in python, we can even override `__getattr__()` and get a dir() of absolutely everything.

    Hope i did understand correctly!

To view, visit change 39747. To unsubscribe, or for help writing mail filters, visit settings.