Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 )
Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on
socket files
......................................................................
Patch Set 5:
(1 comment)
File scripts/osmotestconfig.py:
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980/comment/97c24…
PS5, Line 80: ign = shutil.ignore_patterns('*.cfg',
'*tmp_dummy_sock')
The files are created by the `ctrl_test_runner. […]
It's the first time I actually realize the existence of this socket. I'm not
even sure about its purpose :O
In any case, this file name looks per-project specific. I'd maybe add a new optional
param to copy_config which users inside each project can pass a list of patterns to
ignore.
--
To view, visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664
Gerrit-Change-Number: 30980
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Feb 2023 09:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment