Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 ) Change subject: immediately SCCP RLSD on HNB re-register ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/context_map_sccp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/ad5364a8_c446e8d6 PS1, Line 362: tx_sccp_df1(fi, ranap_msg); : tx_sccp_rlsd(fi); it's a bit odd to see code here that naming-wise claims to directly transmit protocol meassages like RLSD, when in reality it is simply issuing a primitive at the SCCP-USER SAP. I personally don't know the SCCP CO state machines sufficiently off my head to know if the SCCP provider *really* must transmit a RLSD in all situations here. It's a bit like having a function issuing a close() syscall on a socket but then calling that function "tx_tcp_fin()". It seems the existing code already is done that way (the tx_sccp_rlsd function already exists). Seems like I didn't notice it during code reviwew at that time. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4e78617ad39bb73fe92097c8a1a8069da6a7f6a1 Gerrit-Change-Number: 32915 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 15:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment