Attention is currently required from: neels.

View Change

1 comment:

• File src/osmo-hnbgw/context_map_sccp.c:

  • Patch Set #1, Line 362:

    tx_sccp_df1(fi, ranap_msg);
    		tx_sccp_rlsd(fi);
    

    it's a bit odd to see code here that naming-wise claims to directly transmit protocol meassages like RLSD, when in reality it is simply issuing a primitive at the SCCP-USER SAP. I personally don't know the SCCP CO state machines sufficiently off my head to know if the SCCP provider *really* must transmit a RLSD in all situations here.

    It's a bit like having a function issuing a close() syscall on a socket but then calling that function "tx_tcp_fin()".

    It seems the existing code already is done that way (the tx_sccp_rlsd function already exists). Seems like I didn't notice it during code reviwew at that time.

To view, visit change 32915. To unsubscribe, or for help writing mail filters, visit settings.