Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32341 ) Change subject: ms: Drop setting (egprs_)ms_class during bts_alloc_ms() ...................................................................... Patch Set 2: (1 comment) File src/tbf_dl.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32341/comment/c660d425_8084a440 PS2, Line 220: ms = bts_alloc_ms(bts); Not really, because it is set below in lines 224-229. Beforehand they were passed here during allocation because well, something had to be passed. As a result, later on if the MS was allocated here (line 220), the conditions below rresolved as false and nothing was done. If the MS already existed, then the conditions below could resolve to true and be applied there. Now we simply apply them in lines 224-229 if needed and be done with it, much clearer. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36f07dc389f7abe205fc4bcddbde93735f5d5cfc Gerrit-Change-Number: 32341 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Apr 2023 12:47:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment