Attention is currently required from: osmith.

View Change

1 comment:

• File src/tbf_dl.cpp:

  • Patch Set #2, Line 220: ms = bts_alloc_ms(bts);

    is it not needed to set ms_class and egprs_ms_class here?

    Not really, because it is set below in lines 224-229. Beforehand they were passed here during allocation because well, something had to be passed. As a result, later on if the MS was allocated here (line 220), the conditions below rresolved as false and nothing was done.
    If the MS already existed, then the conditions below could resolve to true and be applied there.

    Now we simply apply them in lines 224-229 if needed and be done with it, much clearer.

To view, visit change 32341. To unsubscribe, or for help writing mail filters, visit settings.