Change in osmocom-bb[master]: layer23: Move osmocom_ms to a separate file - gerrit-log

17 Jan 2023


      Attention is currently required from: neels, pespin, msuraev.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30960 )
Change subject: layer23: Move osmocom_ms to a separate file
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/0e8627d7_797e5c9b 
PS5, Line 269: 	if (!ms) {
...
Simply removing this error check is wrong.
resolving this, there's now OSMO_ASSERT(ms);
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30960
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icb4891cc1e4a0ecb5f09cb8a84b0ebe1b91a46b8
Gerrit-Change-Number: 30960
Gerrit-PatchSet: 6
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Tue, 17 Jan 2023 10:19:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment