Attention is currently required from: dexter.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email )

Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically ......................................................................

Patch Set 12: Code-Review-1

(1 comment)

File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34404/comment/5fbc5cee_2ebc817a PS12, Line 698: *ci->verb_info This patch is obviously untested, because this here cannot work. Above, '*ci = cleared_ci;' leaves ci->verb_info == NULL. Now we write data to that NULL pointer.

This code made sense when ci->verb_info was a member of ci, not so when it is a pointer.

But no need to fix this code, refreshing my earlier comment: The ABI problem arises when users assume a smaller size of the struct than libosmo-mgcp-client. So users of libosmo-mgcp-client should do dynamic allocation to ensure being ABI compatible; no need to change the libosmo-mgcp-client code itself, it is always ABI compatible with itself.

So adding the API doc and allocation function is all that is needed in this patch.