Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email )

Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels ......................................................................

Patch Set 3:

(3 comments)

File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/05c7e533_4295d... : PS3, Line 9552: /* TODO: execute( TC_data_facch_tchh48() ); */

maybe write down in the comment that it crashes osmo-bts. […]

I have fixed the problem meanwhile:

* here we call `f_rtpem_activate()`, which does CRCX/MDCX * osmo-bts fix: https://gerrit.osmocom.org/c/osmo-bts/+/38697

so we can uncomment them. Done.

File bts/expected-results.xml:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/2ef193e5_580b3... : PS3, Line 2: <testsuite name='Titan' tests='242' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'>

missing increment here.

Indeed, thanks. Done.

Somehow I remember about this when doing code review but now when writing my own code :P

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/bac0e484_d4980... : PS3, Line 205: <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/>

but we are not running this yet right? so it shouldn't appear here, and it shouldn't for sure be as […]

See the other comment. Marking as resolved.