Attention is currently required from: pespin.

View Change

3 comments:

• File bts/BTS_Tests.ttcn:

  • Patch Set #3, Line 9552: /* TODO: execute( TC_data_facch_tchh48() ); */

    maybe write down in the comment that it crashes osmo-bts. […]

    I have fixed the problem meanwhile:

    • here we call `f_rtpem_activate()`, which does CRCX/MDCX
    • osmo-bts fix: https://gerrit.osmocom.org/c/osmo-bts/+/38697

    so we can uncomment them. Done.

• File bts/expected-results.xml:

  • Patch Set #3, Line 2: <testsuite name='Titan' tests='242' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'>

    missing increment here.

    Indeed, thanks. Done.

    Somehow I remember about this when doing code review but now when writing my own code :P

  • Patch Set #3, Line 205: <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/>

    but we are not running this yet right? so it shouldn't appear here, and it shouldn't for sure be as […]

    See the other comment. Marking as resolved.

To view, visit change 38696. To unsubscribe, or for help writing mail filters, visit settings.