Attention is currently required from: fixeria, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31497 )
Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect ......................................................................
Patch Set 10:
(3 comments)
Patchset:
PS10: excellent, +2 from me, just that reference to a non existent function...
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/0506925e_cbd6f8b5 PS10, Line 971: pdch_deact_bts there is no pdch_deact_bts() ... (i'd just write the comment again / ok if you want to fix the reference instead)
File src/osmo-bsc/timeslot_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/34734080_db5a332d PS9, Line 1128: NOTE
I like to use it to mark comments which I think are more important then other comments. […]
it always throws me off a bit ... like, if a comment is not noteworthy, then we can drop the comment ... it's an almost certain way to know that you are the author of the code =)
-
neels