Attention is currently required from: fixeria, dexter.

View Change

3 comments:

• Patchset:

  • Patch Set #10:

    excellent, +2 from me, just that reference to a non existent function...

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #10, Line 971: pdch_deact_bts

    there is no pdch_deact_bts() ... (i'd just write the comment again / ok if you want to fix the reference instead)

• File src/osmo-bsc/timeslot_fsm.c:

  • Patch Set #9, Line 1128: NOTE

    I like to use it to mark comments which I think are more important then other comments. […]

    it always throws me off a bit ... like, if a comment is not noteworthy, then we can drop the comment ... it's an almost certain way to know that you are the author of the code =)

To view, visit change 31497. To unsubscribe, or for help writing mail filters, visit settings.