Attention is currently required from: neels.
pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email )
Change subject: add osmo_stream_cli_set_name_f() ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
FYI, this patch fell out of my work some months ago, which is now probably obsolete. […]
I'm fine with merging this, I know several places where we are actually generating a string in a stack allocated buf then passing it to this API. I'd welcome though if you also add to this patch the counterpart for osmo_stream_srv (I think we can skip it for osmo_stream_srv_link, since usually there's no multiple of those which needs string generation).
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/19e96e79_0acaf45e... : PS1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name); I'd rather duplicate a couple lines than going through the whole vararg parsing here....