Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I'm fine with merging this, I know several places where we are actually generating a string in a stack allocated buf then passing it to this API. I'd welcome though if you also add to this patch the counterpart for osmo_stream_srv (I think we can skip it for osmo_stream_srv_link, since usually there's no multiple of those which needs string generation). File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/19e96e79_0acaf45… : PS1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name); I'd rather duplicate a couple lines than going through the whole vararg parsing here.... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>