Attention is currently required from: dexter, fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email )
Change subject: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/38076/comment/084ba99a_5758962d?usp… :
PS1, Line 426: bsc_co_located_pcu
Shouldn't this check be done in a common place
like `pcu_sock_send()`?
That's too late, since you don't have bts
information there, only the uint8_t bts_nr which is already malfunctioning.
I think in here it's fine.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169
Gerrit-Change-Number: 38076
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Sep 2024 15:43:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>