Attention is currently required from: neels, fixeria, msuraev.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 )
Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8 ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
would be nice maybe to say in the commit log how the new test vectors were obtained... […]
Yes, manually. Unfortunately I could not make the PCU to use MCS9 so that is still missing. MCS9 would have been important since it uses its own TRAU frame format.
File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/01eba544_0a5b898c PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav);
that is true, and i wondered the same: why does this unit test not simply have an array with all tes […]
Since I receive a lot of criticism regarding the code duplication I will clean this up in a follow up patch. However, In general I think it is not worth the effort to optimize unit tests to the absolute maximum possible. But I see the point in this case. So lets merge this as it is to prevent merge conflicts in the follow up patch.
-
dexter