Attention is currently required from: dexter, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email ) Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: btw, I think this code change can also be applied to the other place where you removed the #ifdef in the previous commit. File src/gprs_rlcmac_sched.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/35151/comment/c2b472ef_35de08e1 PS1, Line 486: * way we help BTS energy saving (on TRX!=C0) by sending nothing IIRC osmo-bts-trx does something slightly different if it detects no block is to be sent because no one is listening, like decreasing the Tx power during that time. If MS are listening on that PDCH, then we still need to transmit at regular Tx power. @vyanitskiy@sysmocom.de probably remembers better. In any case, I'd rather leave the comment where it was, immedatelly after the parent "else" block, since it refers to the whole case where an RLCMAC Dummy Block would be sent. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iadb62748b18605bf158169b317f880352bc0a5a6 Gerrit-Change-Number: 35151 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 15:06:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment