Attention is currently required from: dexter, fixeria.
2 comments:
Patchset:
btw, I think this code change can also be applied to the other place where you removed the #ifdef in the previous commit.
File src/gprs_rlcmac_sched.cpp:
Patch Set #1, Line 486: * way we help BTS energy saving (on TRX!=C0) by sending nothing
I don't get why this is energy saving. The dummy block is sent in any case. […]
IIRC osmo-bts-trx does something slightly different if it detects no block is to be sent because no one is listening, like decreasing the Tx power during that time. If MS are listening on that PDCH, then we still need to transmit at regular Tx power. @vyanitskiy@sysmocom.de probably remembers better.
In any case, I'd rather leave the comment where it was, immedatelly after the parent "else" block, since it refers to the whole case where an RLCMAC Dummy Block would be sent.
To view, visit change 35151. To unsubscribe, or for help writing mail filters, visit settings.