[S] Change in libosmo-sccp[master]: vty: Retrieve IP addr set from sk when dumping xUA server - gerrit-log

12 Dec 2023


      Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35242?usp=email )
Change subject: vty: Retrieve IP addr set from sk when dumping xUA server
......................................................................
Patch Set 2:
(2 comments)
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35242/comment/086979e2_84eb283b 
PS2, Line 613: 	char buf[OSMO_SOCK_MAX_ADDRS * INET6_ADDRSTRLEN + OSMO_SOCK_MAX_ADDRS + 2 + 6 + 1];
maybe put it into a define? see also https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/82dc01d3_b7055e6e...
https://gerrit.osmocom.org/c/libosmo-sccp/+/35242/comment/0f9dbc2a_d3925ddf 
PS2, Line 632: 				num_hostbuf = ARRAY_SIZE(hostbuf);
in https://gerrit.osmocom.org/c/libosmocore/+/35180 you print <need-more-bufs!> in that case, why not here too?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35242?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I331b6e2fe11cd97e286b7ba684d4a17b8055f9d4
Gerrit-Change-Number: 35242
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 12 Dec 2023 12:30:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment