[S] Change in osmo-bts[master]: pcuif_proto: clean up last remains of old PCUIF v10 - gerrit-log

10 Oct 2023


      Attention is currently required from: dexter, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34707?usp=email )
Change subject: pcuif_proto: clean up last remains of old PCUIF v10
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File include/osmo-bts/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bts/+/34707/comment/04b2a897_c1b38322 
PS1, Line 32: #define PCU_IF_SAPI_AGCH	0x02	/* (deprecated) */
They were deprecated with v11, but since v12 which you will introduce now they will be no-longer supported, hence they should actually be removed.
AFAIU the protocol version is checked at startup, so there shouldn't be problems with different versions using the same value for different topics.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34707?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I04f7108c94c99c9920192177087748e8b89b3106
Gerrit-Change-Number: 34707
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 10 Oct 2023 14:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment