Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39239?usp=email )
Change subject: mgw: MDCX: Split mgcp header pars parsing into a previous step ......................................................................
Patch Set 4:
(1 comment)
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/51d6fdc4_eb73933a?usp=... : PS4, Line 1122: remote_osmux_cid = mgcp_osmux_setup(endp, line); `handle_create_con()` contains the following code: ``` if (hpars->remote_osmux_cid != MGCP_PARSE_HDR_PARS_OSMUX_CID_UNSET) mgcp_trunk_osmux_init_if_needed(trunk); ```
Should you add that to `handle_modify_con()` as well after removing `mgcp_osmux_setup()` here?