pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39713?usp=email ) Change subject: cosmetic: Drop incorrect comment ...................................................................... cosmetic: Drop incorrect comment The writer of this commit wrongly interpreted conn->end to be an mgcp_endpoint, but it's actually an struct mgcp_rtp_end, hence codecs are set per connection as expected. Change-Id: I773065972342b8cedc900e3d194c48775c3adb5a --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/13/39713/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 34b0111..916a284 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1009,7 +1009,6 @@ goto error2; } /* Upgrade the conn type RTP_DEFAULT->RTP_IUUP if needed based on requested codec: */ - /* TODO: "codec" probably needs to be moved from endp to conn */ if (conn_rtp->type == MGCP_RTP_DEFAULT && strcmp(conn_rtp->end.cset.codec->subtype_name, "VND.3GPP.IUFP") == 0) { rc = mgcp_conn_iuup_init(conn_rtp); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I773065972342b8cedc900e3d194c48775c3adb5a Gerrit-Change-Number: 39713 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>