Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 ) Change subject: gmm: Implement rx GMM STATUS msg ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: btw, it might make sense to do all that kind of logging in a generic place before dispatching to individual functions. The message name could come from a value_string, and the size checks could come from a table/array indexed by msg_type. This would reduce a lot of boilerplate logging code in various places. File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33001/comment/468d984f_d9c78faf PS4, Line 1232: GMM GMM 2x GMM? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803 Gerrit-Change-Number: 33001 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 May 2023 12:42:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment