Attention is currently required from: jolly.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email )

Change subject: Use polling based LAPDm with frame numbers ......................................................................

Patch Set 3:

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/463ddebd_8bae64ec PS2, Line 1975: (fn + GSM_MAX_FN - 1) % GSM_MAX_FN Feel free to use `GSM_TDMA_FN_SUB(fn, 1)` here.

File src/common/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/ab43d4eb_54f3283e PS3, Line 686: #if 0 IMO, we should at least log a `NOTICE` message here saying that the T200 values from the BSC and ignored and not applied. Also, a comment in code explaining why we ignore these values would be very welcome. Thanks!